-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default "Sound" behavior #9
Comments
I'm keen on #1 and then #2 as a bonus.
Do all platforms support sounds (both preset and custom i.e. path to an
MP3/wav?)
…On Mon, 3 Dec 2018, 5:01 PM Tyler James Leonhardt, ***@***.***> wrote:
Some options:
1. whatever the default sound is for that platform (if the platform
supports sound)
2. no sound at all
Number 1 means we'd support a -Silent switch parameter
Number 2 means we'd support a -Sound $someStr parameter
I think we should do number 1 first and then add number 2 so that users
can specify their own sound files
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGojCn6YNn1Tl8WTNeudzdhLlFQciHdqks5u1KIogaJpZM4Y91vf>
.
|
It looks like linux supports it as a http://www.galago-project.org/specs/notification/0.9/x344.html
looks like there's no default sound though. Maybe for linux, no sound is a good default... and then we can allow users to specify the sound file which should work cross-plat. There's some work I'll have to do in PSNotifySend to support this. |
While figuring out how to do it I noticed there was an open issue to add the technique to the documentation, which I then did, so the way I'm using it in MacNotify is also the documented example: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_functions_advanced_parameters?view=powershell-6#dynamic-validateset-values |
So I've done a fair bit of playing with this today. It looks like all the major distros (CentOS,Ubuntu,Debian,Fedora) have a paplay binary which can play any filetype. Testing againt what's it /usr/share/sounds/gnome/default/alerts on each system yielded 100% success rate in hearing the audio. Armed with that data, I intend to stream tonight on a new branch which adds the -Sound parameter to Send-OSNotification. |
I did the work in PSNotifySend to expose a |
Also, I noticed that
and I'm wondering if that's useful here... not quite sure. |
Some options:
Number 1 means we'd support a
-Silent
switch parameterNumber 2 means we'd support a
-Sound $someStr
parameterI think we should do number 1 first and then add number 2 so that users can specify their own sound files
The text was updated successfully, but these errors were encountered: