Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using proper loopback requests for runtime checks #526

Open
swissspidy opened this issue Jul 15, 2024 · 0 comments
Open

Evaluate using proper loopback requests for runtime checks #526

swissspidy opened this issue Jul 15, 2024 · 0 comments
Labels
Checks Audit/test of the particular part of the plugin [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@swissspidy
Copy link
Member

The runtime checks right now are not really smart, they just modify the global WP_Query to "navigate to" specific URLs and then see what kind resources were enqueued/inserted etc. That will never be as accurate as an actual HTTP request to the frontend.

This won't be very straightforward though, because for the runtime checks PCP spins up a separate WordPress install that doesn't affect the main site. So the system under test (SUT) won't actually be accessible via loopback request out of the box. But there might be some ways to address that, for example with some special query parameters or so.

It could also be more feasible for cases like the GitHub Action with a more closed down environment.

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature Checks Audit/test of the particular part of the plugin labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checks Audit/test of the particular part of the plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant