You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for providing such library. Really useful 👍. I have some suggestions for the library. I am not sure about the best way to proceed with the feature requests and implementations. Here's the list of the improvements.
Prevent using reserved keywords for the property names automatically. This can easily be done by adding # or a symbol as a prefix to all the reserved words from dynamoDB (more info here). Additionally, if you add expression attribute name alias, will it be reflected on the filter expression as well?
Add a test data set to include test cases in order to keep up with changes and to prevent introducing new errors
I think the BuilderType logic is reversed. The document client is the one that requires marshalled values, and the dynamodb is the opposite. Correct me if i am wrong. For the marshalling part, you don't need to add yourself logic to it. The sdk for dynamodb already includes a helper. Perhaps there was a reason behind it.
Let me know what do you think about those changes.
The text was updated successfully, but these errors were encountered:
Hey there.
First of all, thank you for providing such library. Really useful 👍. I have some suggestions for the library. I am not sure about the best way to proceed with the feature requests and implementations. Here's the list of the improvements.
Prevent using reserved keywords for the property names automatically. This can easily be done by adding
#
or a symbol as a prefix to all the reserved words from dynamoDB (more info here). Additionally, if you add expression attribute name alias, will it be reflected on the filter expression as well?Add a test data set to include test cases in order to keep up with changes and to prevent introducing new errors
I think the BuilderType logic is reversed. The document client is the one that requires marshalled values, and the dynamodb is the opposite. Correct me if i am wrong. For the marshalling part, you don't need to add yourself logic to it. The sdk for dynamodb already includes a helper. Perhaps there was a reason behind it.
Let me know what do you think about those changes.
The text was updated successfully, but these errors were encountered: