Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improvements #1

Open
ricardoribas opened this issue Jul 7, 2022 · 0 comments
Open

Feature Request: Improvements #1

ricardoribas opened this issue Jul 7, 2022 · 0 comments

Comments

@ricardoribas
Copy link

ricardoribas commented Jul 7, 2022

Hey there.

First of all, thank you for providing such library. Really useful 👍. I have some suggestions for the library. I am not sure about the best way to proceed with the feature requests and implementations. Here's the list of the improvements.

  1. Prevent using reserved keywords for the property names automatically. This can easily be done by adding # or a symbol as a prefix to all the reserved words from dynamoDB (more info here). Additionally, if you add expression attribute name alias, will it be reflected on the filter expression as well?

  2. Add a test data set to include test cases in order to keep up with changes and to prevent introducing new errors

  3. I think the BuilderType logic is reversed. The document client is the one that requires marshalled values, and the dynamodb is the opposite. Correct me if i am wrong. For the marshalling part, you don't need to add yourself logic to it. The sdk for dynamodb already includes a helper. Perhaps there was a reason behind it.

Let me know what do you think about those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant