Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logrow + fix benchmark folder #35

Open
JernKunpittaya opened this issue May 12, 2024 · 0 comments
Open

Optimize logrow + fix benchmark folder #35

JernKunpittaya opened this issue May 12, 2024 · 0 comments

Comments

@JernKunpittaya
Copy link
Collaborator

This issue was already mentioned in benchmark folder itself, see more info in that folder's README, but basically

'logrow' can be chosen arbitrarily between min(log_2(number of rows), log_2(lookup range)) to max(log_2(number of rows), log_2(lookup range)). The trade off is that if we choose lower logrow value , we will face with more "columns for non-linearity table".

For now, based on our experiment, the best value to select logrow is to select the lowest logrow in the range such that ceiling(lookup_range/2^logrow) <=5

Hence,

  1. We should incorporate this optimization into zkstats itself natively
  2. Due to some changes in zkstats flow from merging PR#34, we should update our benchmark folder accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant