Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace functionality for offline backup with -S option, make -S option default #188

Open
abbbi opened this issue Jun 24, 2024 · 0 comments
Labels
code-cleanup enhancement New feature or request

Comments

@abbbi
Copy link
Owner

abbbi commented Jun 24, 2024

At the moment there are two ways for backing up offline virtual machines:

  1. Use the offline backup functionality in virtnbdbackup where the code starts the NBD Service using qemu-nbd, only copy backup works with this mode
  2. Use option -S which starts VM in non-operational mode and enables all backup modes to work correctly.

I think the situations where option 1) is the better way for backing up the virtual machine are very limited. I cant think of situations where the virtual machine is not able to be started in on-operational mode.

It may make sense to enable option -S by default and remove all the legacy code from the codebase that handles starting the local and remote qemu-nbd processes for the offline backup.

@abbbi abbbi added enhancement New feature or request code-cleanup labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant