Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added aria-labels #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added aria-labels #120

wants to merge 3 commits into from

Conversation

isidrohan
Copy link

Closes #116

Add aria-label attributes for better accessibility

Changes

  • Added aria-label attributes to key components for accessibility
    • Navbar: Added label for navigation
    • SampleDropdown: Added label for dropdown
    • UseShare: Added label for share options
    • Errors: Added aria-live="assertive" to announce errors
    • Collapse: Added label for collapsible panels
    • ToggleDarkMode: Added label for dark mode toggle button
    • FullScreenModal: Added label for fullscreen modal
    • AgreementHtml: Added label for agreement preview
    • Footer: Added label for footer content
    • Added aria-label to mobile view message for clarity

Flags

  • Ensure that screen reader users can navigate through the app efficiently with the added labels.
  • Review component accessibility on various devices for potential improvement.

Screenshots or Video

  • None provided at this time.

Related Issues

@isidrohan isidrohan requested a review from a team as a code owner December 21, 2024 16:07
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 4ac7dcc
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/677e9f26e6d59600083b4930
😎 Deploy Preview https://deploy-preview-120--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanketshevkar
Copy link
Member

Hi @isidrohan
Thanks for your contribution!
Can you please complete a DCO signoff for your commits? Please look at the PR check details for the fix.

@isidrohan isidrohan force-pushed the 116-feat/added-aria-labels branch from ad8a83d to 8d368c6 Compare January 2, 2025 05:54
@isidrohan
Copy link
Author

Hello @sanketshevkar ,
Can you please review it once, DCO signoff check is verified.

DianaLease
DianaLease reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added one question.

src/components/Navbar.tsx Outdated
Comment on lines 87 to 97
const menuItemStyle = (key: string, isLast: boolean) => ({
display: "flex",
alignItems: "center",
padding: screens.md ? "0 20px" : "0",
backgroundColor:
hovered === key ? "rgba(255, 255, 255, 0.1)" : "transparent",
height: "65px",
borderRight:
screens.md && !isLast ? "1.5px solid rgba(255, 255, 255, 0.1)" : "none",
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this styling was removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReAdded menuItemStyle
It was just happened by mistake.
Kindly review this now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to add it back where it was used as well. Please also make sure your new commits have DCO signoff. Thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReAdded menuItemStyle
kindly review this now.

DianaLease
DianaLease requested changes Jan 8, 2025
View reviewed changes
src/components/Navbar.tsx Outdated
>
<div
style={{
cursor: "pointer",
...menuItemStyle("home", false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it back where it is used as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added kindly review it.

src/components/Navbar.tsx
@@ -139,22 +144,22 @@ function Navbar({ scrollToExplore }: { scrollToExplore: any }) {
<>
<div
style={{
...menuItemStyle("explore", false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added kindly review it.

src/components/Navbar.tsx Show resolved Hide resolved
@isidrohan
Added aria-labels
1e4b3bb 
Signed-off-by: Siddharth Rohan <[email protected]>
@isidrohan
ReAdded the MenuItemStyle
0e594ee 
Signed-off-by: Siddharth Rohan <[email protected]>
@isidrohan
Readded the menuItemStyle
4ac7dcc 
Signed-off-by: Siddharth Rohan <[email protected]>
@isidrohan isidrohan force-pushed the 116-feat/added-aria-labels branch from 2a5d9b7 to 4ac7dcc Compare January 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aria-labels for buttons, links, and icons to improve accessibility
3 participants
@isidrohan @sanketshevkar @DianaLease