Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply acidanthera/VoodooPS2#27 to BrightnessKeys #1187

Closed
usr-sse2 opened this issue Sep 28, 2020 · 3 comments · Fixed by acidanthera/BrightnessKeys#4
Closed

Apply acidanthera/VoodooPS2#27 to BrightnessKeys #1187

usr-sse2 opened this issue Sep 28, 2020 · 3 comments · Fixed by acidanthera/BrightnessKeys#4
Labels
project:brkeys

Comments

@usr-sse2
Copy link
Contributor

acidanthera/VoodooPS2#27
@Sniki
Copy link

Sniki commented Sep 30, 2020 •
edited
Loading

Is BrightnessKeys going to be a plugin kext for VoodooPS2 (bundled with VoodooPS2) similarly how VoodooInput is ?

@vit9696
Copy link
Contributor

vit9696 commented Sep 30, 2020

It will be a separate kext, which can be used with both VoodooPS2 and other kexts like VoodooI2C or VoodooSMBus. That is the primary reason for separation.

@usr-sse2
Copy link
Contributor Author

usr-sse2 commented Oct 1, 2020 •
edited
Loading

Don't know if there are I2C or SMBus keyboards.
Another reason is that users can decide to continue using ACPI patches with VoodooPS2 (and not install BrightnessKeys).

@zhen-zen zhen-zen mentioned this issue Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project:brkeys
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added version info property zhen-zen/BrightnessKeys
3 participants
@usr-sse2 @vit9696 @Sniki