Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental data frame numbers are over-specified #336

Open
stvdwtt opened this issue Nov 9, 2024 · 1 comment
Open

Experimental data frame numbers are over-specified #336

stvdwtt opened this issue Nov 9, 2024 · 1 comment
Assignees

Comments

@stvdwtt
Copy link
Collaborator

stvdwtt commented Nov 9, 2024

Currently we have a log of all of the frames to be assimilated and separately have input file entries for first frame (optional, default=0) and the last frame (mandatory). We've had a few times during experiments when we were confused that adamantine stopped assimilating frames.

I think that the log file should be the place where we specify which frames we want to assimilate.

I see two options for fixing this:

  1. Remove the first frame and last frame options entirely.
  2. Make the last frame optional and make std::numeric_limits<unsigned int>::max() the default.

@Rombur, do you have a preference?

@stvdwtt stvdwtt self-assigned this Nov 9, 2024
@Rombur
Copy link
Member

Rombur commented Nov 11, 2024

Let's just remove these options. We have too many inputs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants