Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double dot before dnsforwarding.com CNAME #1

Open
adriaandotcom opened this issue May 6, 2018 · 0 comments
Open

Double dot before dnsforwarding.com CNAME #1

adriaandotcom opened this issue May 6, 2018 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adriaandotcom
Copy link
Owner

Sometimes it creates a double dot before the CNAME like this:

jksdfksdf9e93jf2ij23fjkl..dnsforwarding.com

In the code .trim('.') is used, but that does not work:

https://github.com/adriaanvanrossum/dnsforwarding.com/blob/5006c0a233ebc67ab4fb53eeec14df64964b61f0/docs/index.html#L167

Replace this with something like this:

.replace(/^\.+|\.+$/g, '');
@adriaandotcom adriaandotcom added bug Something isn't working good first issue Good for newcomers labels May 6, 2018
@adriaandotcom adriaandotcom self-assigned this May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant