Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better imagefactory error handling #82

Open
jprovaznik opened this issue Dec 16, 2012 · 0 comments
Open

Better imagefactory error handling #82

jprovaznik opened this issue Dec 16, 2012 · 0 comments

Comments

@jprovaznik
Copy link
Contributor

Methods create_factory_target_image and create_factory_provider_image don't handle errors properly - there is rescue block, which re-rises an exception:
rescue => e
# TODO Add proper error handling
raise e
end

It would be better to save the error into object.errors instead of propagating the exception.

I think this is not a blocker for 2.0 release, although a user in Conductor gets only flash error message on empty page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant