Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding aggkit-prover binary #14

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat: adding aggkit-prover binary #14

merged 1 commit into from
Jan 27, 2025

Conversation

Freyskeyd
Copy link
Member

Description

This PR is initiating the aggkit-prover binary, refactoring a bit the different crates to reuse code as much as possible.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner January 23, 2025 16:00
@Freyskeyd Freyskeyd linked an issue Jan 23, 2025 that may be closed by this pull request
Have a binary to launch the aggkit-prover #6
Closed
@Freyskeyd Freyskeyd force-pushed the feature/adding-aggkit-prover-binary branch from fbaf802 to 0592421 Compare January 27, 2025 08:49
@Freyskeyd
feat: adding aggkit-prover binary
8d4eeab 
Signed-off-by: Simon Paitrault <[email protected]>
@Freyskeyd Freyskeyd force-pushed the feature/adding-aggkit-prover-binary branch from 0592421 to 8d4eeab Compare January 27, 2025 09:24
atanmarko
atanmarko approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@atanmarko atanmarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets merge this to get us started, will refactor further as needed.

@Freyskeyd Freyskeyd merged commit 356d8b6 into main Jan 27, 2025
8 checks passed
@Freyskeyd Freyskeyd deleted the feature/adding-aggkit-prover-binary branch January 27, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@iljakuklic iljakuklic Awaiting requested review from iljakuklic iljakuklic is a code owner automatically assigned from agglayer/agglayer-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a binary to launch the aggkit-prover
2 participants
@Freyskeyd @atanmarko