Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEMINI 2.3 fixes #5

Open
archaeogeek opened this issue Mar 8, 2021 · 4 comments
Open

GEMINI 2.3 fixes #5

archaeogeek opened this issue Mar 8, 2021 · 4 comments

Comments

@archaeogeek
Copy link
Member

Issue by nmtoken
Mon Nov 2 17:27:37 2020
Originally opened as AGIuk/Schematron#4


Proposed changes to GEMINI 2.3.n schematron


nmtoken included the following code: https://github.com/AGIuk/Schematron/pull/4/commits

@archaeogeek
Copy link
Member Author

Comment by archaeogeek
Tue Nov 3 11:21:31 2020


Any chance of a diff between this and the previous version?

@archaeogeek
Copy link
Member Author

Comment by nmtoken
Tue Nov 3 16:27:51 2020


Added a diff between the files, I uploaded a new file rather than change the existing one for two reasons, first is that the original file has a version number attached, and second related to that is that we may want a candidate release for all new proposed changes. These changes should be for consideration/testing at the moment, not latest GEMINI.

@archaeogeek
Copy link
Member Author

Comment by PeterParslow
Thu Feb 4 16:27:09 2021


I challenge the test that triggers MI-18a (line 33 in the diff)

test="($hierarchyLevelCLValue = 'dataset' or $hierarchyLevelCLValue = 'series') and ($srES > 0 and $srES > 0)

surely one of the two $srES should be $srD?

And you would then want to fix the report that it gives (line 35 in the diff)

@archaeogeek
Copy link
Member Author

Comment by nmtoken
Wed Feb 10 10:24:53 2021


This is now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant