Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Use the aiida-pseudo package for installing pseudos #215

Closed
giovannipizzi opened this issue Jun 18, 2020 · 8 comments · Fixed by #366
Closed

👌 IMPROVE: Use the aiida-pseudo package for installing pseudos #215

giovannipizzi opened this issue Jun 18, 2020 · 8 comments · Fixed by #366
Assignees
Labels
priority/mission-critical Needs to be fixed (before next event) section/all Applies to all sections type/improve Improving already existing content

Comments

@giovannipizzi
Copy link
Member

giovannipizzi commented Jun 18, 2020

This would avoid to run these lines (see #214):

mkdir sssp_pseudos
wget 'https://archive.materialscloud.org/record/file?filename=SSSP_1.1_PBE_efficiency.tar.gz&record_id=23&file_id=d2ce4186-bf76-4e05-8b39-444b4da30273' -O SSSP_1.1_PBE_efficiency.tar.gz
tar -C sssp_pseudos -zxvf SSSP_1.1_PBE_efficiency.tar.gz
verdi data upf uploadfamily sssp_pseudos 'SSSP' 'SSSP pseudopotential library'

@sphuber is the package ready? What would be the equivalent commands? @chrisjsewell is it already in the quantum mobile?

@chrisjsewell
Copy link
Member

chrisjsewell commented Jun 18, 2020

is it already in the quantum mobile?

Not at present. This relates to marvel-nccr/ansible-role-aiida#35

@sphuber
Copy link
Contributor

sphuber commented Jun 18, 2020

It currently is working, see master branch: https://github.com/aiidateam/aiida-pseudo/commits/master
But I haven't released it yet, because I haven't had the time to discuss with other developers about the design/naming choices etc. Also some advanced functionality that was in aiida-sssp, i.e. to automatically get the cutoffs for a given structure, have not yet been ported. Also, depending on how it is used, it might require an update of aiida-quantumespresso.

@chrisjsewell chrisjsewell changed the title Should we use the aiida-pseudo package for loading a new pseudo family? Use the aiida-pseudo package for loading a new pseudo family in next tutorial Jun 27, 2020
@chrisjsewell
Copy link
Member

I believe the answer is no then for the coming tutorial, so I've changed the name of this issue as a reminder for the next tutorial

@ltalirz
Copy link
Member

ltalirz commented Jun 30, 2020

Would people agree to replace these 4 commands with a simple import?

verdi import -n "https://archive.materialscloud.org/record/file?file_id=2a59c9e7-9752-47a8-8f0e-79bcdb06842c&record_id=23&filename=SSSP_1.1_PBE_efficiency.aiida"

Perhaps this section 2.2.4 can also be deleted entirely and the pseudopotential import moved to a place where it is needed (not sure people need to see this before starting to run their first calculation).

@sphuber
Copy link
Contributor

sphuber commented Jul 1, 2020

That will import the pseudos, but that won't work with the rest of the tutorial. The tutorial relies on a group of type core.upf existing with the name sssp_pseudos, but the import will create just a group with a randomly generated name and of type core.import. You can use -G sssp_pseudos to get the correct name, but you cannot influence the type. This is important because for example the command in section 3.4.2. will then not show any families. So unfortunately, we cannot simplify this at the moment

@ltalirz
Copy link
Member

ltalirz commented Jul 1, 2020

Ok, thanks for the clarification.

@mbercx mbercx added the section/running-calculations Sections on running calculations and workflows label Jun 9, 2021
@mbercx mbercx added priority/important Not absolutely required, but important to fix priority/mission-critical Needs to be fixed (before next event) section/all Applies to all sections type/improve Improving already existing content and removed priority/important Not absolutely required, but important to fix section/running-calculations Sections on running calculations and workflows labels Jun 9, 2021
@mbercx
Copy link
Member

mbercx commented Jun 9, 2021

Indeed, very important to check this. @ramirezfranciscof I think this will be done first in the "Running calculations" section?

@mbercx mbercx changed the title Use the aiida-pseudo package for loading a new pseudo family in next tutorial 👌 IMPROVE: Use the aiida-pseudo package for installing pseudos Jun 9, 2021
@ltalirz
Copy link
Member

ltalirz commented Jan 31, 2022

@ltalirz ltalirz closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/mission-critical Needs to be fixed (before next event) section/all Applies to all sections type/improve Improving already existing content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants