Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with YAMCS quickstart example #427

Open
rjler opened this issue Feb 13, 2024 · 10 comments · Fixed by #429
Open

Issue with YAMCS quickstart example #427

rjler opened this issue Feb 13, 2024 · 10 comments · Fixed by #429
Labels
source:community type:bug Something isn't working

Comments

@rjler
Copy link

rjler commented Feb 13, 2024

Summary

Followed https://github.com/akhenry/openmct-yamcs#installation and get blank webpage

Steps to Reproduce

  1. Installed and successfully started YAMCS quickstart

  2. Followed the instructions from https://github.com/akhenry/openmct-yamcs#installation
    git clone https://github.com/akhenry/openmct-yamcs.git
    cd openmct-yamcs
    npm install
    npm run build:example
    npm start

  3. Opened firefox to http://192.168.0.69:9000/
    Displays a blank black window

  4. Opened the developer tools - displays the following:
    Screenshot 2024-02-13 at 4 14 25 PM

Environment

npm -version
9.6.7
node -v
v18.17.1

Ubuntu 20.04

@rjler rjler added the type:bug Something isn't working label Feb 13, 2024
@ozyx
Copy link
Collaborator

ozyx commented Feb 14, 2024

@rjler
Thanks for raising this, we will investigate. In the meantime in order to unblock you, could you try using build:example:master to install the latest Open MCT and see if the quickstart example works for you?

Thanks again. Let us know if you run into any other issues.

@unlikelyzero
Copy link
Collaborator

@rjler this is a bug with our optional dependency checks. I have opened a PR to fix this

@rjler
Copy link
Author

rjler commented Feb 15, 2024

Thanks for help ...

npm run build:example:master
Fixed the initial issue but encountered 'missing taxonomy'

spinning

From the developer tools:
Screenshot 2024-02-15 at 10 47 36 AM

**Modified example/index.js ( changed localhost: to host ip ): **
Screenshot 2024-02-15 at 10 48 41 AM

**Working as expected: **
Screenshot 2024-02-15 at 11 02 02 AM

@unlikelyzero
Copy link
Collaborator

@rjler can you try using 0.0.0.0 instead of your host IP? It looks like there's a CORS issue

@rjler
Copy link
Author

rjler commented Feb 16, 2024

Modified example/index.js

const config = {
"yamcsDictionaryEndpoint": "http://0.0.0.0:9000/yamcs-proxy/",
"yamcsHistoricalEndpoint": "http://0.0.0.0:9000/yamcs-proxy/",
"yamcsWebsocketEndpoint": "ws://0.0.0.0:9000/yamcs-proxy-ws/",
"yamcsUserEndpoint": "http://0.0.0.0:9000/yamcs-proxy/api/user/",
"yamcsInstance": "myproject",
"yamcsProcessor": "realtime",
"yamcsFolder": "myproject",
"throttleRate": 1000,
"maxBatchSize": 15
};

Get missing:taxonomy

From dev tools:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://0.0.0.0:9000/yamcs-proxy/api/user/. (Reason: CORS request did not succeed). Status code: (null).

@ozyx
Copy link
Collaborator

ozyx commented Feb 16, 2024

@rjler how are you running yamcs? are you using the provided Makefile in quickstart to spin everything up via docker?

@rjler
Copy link
Author

rjler commented Feb 19, 2024

quickstart: From https://github.com/akhenry/openmct-yamcs?tab=readme-ov-file#prerequisites
followed the quickstart link to: https://github.com/yamcs/quickstart. The followed the instructions.
No docker involved, executing YAMCS quickstart and openMCT on the same Ubuntu host. Using Firefox, on a Mac, on the same network ( 192.168.0.xxx ) to access openMCT ( 192.168.0.69:9000 ).

@ozyx
Copy link
Collaborator

ozyx commented Feb 22, 2024

@rjler Thanks for the info. Seems like the non-docker workflow has broken due to some recent change-- will investigate. In the meantime, you may try the docker workflow and see if that fits your needs.

@ozyx ozyx self-assigned this Feb 22, 2024
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 27, 2024
@akhenry akhenry removed this from the Target:4.0.0 milestone Mar 18, 2024
@unlikelyzero
Copy link
Collaborator

Looks like this was closed as a part of #466

@charlesh88
Copy link
Collaborator

charlesh88 commented Sep 10, 2024

The solution in #466 is a good workaround, but not a solution. Per @akhenry, we should:

  1. Release a new version of Open MCT.
  2. Immediately add a note to README.md that with the npm run build:example:master solution for users that encounter the problem as noted in this issue.

ozyx added a commit that referenced this issue Nov 1, 2024
* adding functionality for initial load example display layout

* readding mistakenly removed line

* New example default display and supporting components.

* New example default display and supporting components.

* Finalized new example default display and supporting components.
- New main flex layout exercises conditionals and most available object views.
- Modded index.js to look for new main layout name.

* Updated README.md to include workaround for issue as noted in #427.

* Enhancements to example Health display.

* fix: add retry / polling limits so browser doesn't hang

* chore: lint:fix

* test: add smoke test for default display

---------

Co-authored-by: Jamie V <[email protected]>
Co-authored-by: Mazzella, Jesse D. (ARC-TI)[KBR Wyle Services, LLC] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants