-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm private repos aren't working #226
Comments
@Brightside56 the changes from #201 were released today in v0.1.0-rc.34. Did those improvements somehow fix this for you in a way I wasn't anticipating? |
@krancour oops, sorry, I'll re-open it, those changes make helm working again generally, but not private repos |
Thanks @Brightside56. I sensed this may have been closed in error. Glad I checked. |
Kargo proper recently did something about this in akuity/kargo#1977 It does a We could take a similar approach here and do This leaves the main question as one of how to pass multiple helm chart repo credentials to kargo render securely without it being a terrible UX. |
With fresh versions of kargo-render (which started to use ArgoCD repo server for rendering helm) - helm private repos aren't working anymore (kargo credentials same as ArgoCD credentials borrowing). To make it working with repo server - kargo-render should most probably pass credentials and allowed sources here
kargo-render/internal/argocd/render.go
Line 114 in 1bdf2f6
The text was updated successfully, but these errors were encountered: