diff --git a/src/interfaces/IPlugin.sol b/src/interfaces/IPlugin.sol index c5798807..0b74df86 100644 --- a/src/interfaces/IPlugin.sol +++ b/src/interfaces/IPlugin.sol @@ -16,7 +16,8 @@ enum ManifestAssociatedFunctionType { NONE, // Function belongs to this plugin. SELF, - // Function belongs to an external plugin provided as a dependency during plugin installation. + // Function belongs to an external plugin provided as a dependency during plugin installation. Plugins MAY depend + // on external validation functions. It MUST NOT depend on external hooks, or installation will fail. DEPENDENCY, // Resolves to a magic value to always bypass runtime validation for a given function. // This is only assignable on runtime validation functions. If it were to be used on a user op validation function, @@ -71,7 +72,7 @@ struct PluginMetadata { // The author field SHOULD be a username representing the identity of the user or organization // that created this plugin. string author; - // String desciptions of the relative sensitivity of specific functions. The selectors MUST be selectors for + // String descriptions of the relative sensitivity of specific functions. The selectors MUST be selectors for // functions implemented by this plugin. SelectorPermission[] permissionDescriptors; } diff --git a/src/interfaces/IPluginManager.sol b/src/interfaces/IPluginManager.sol index 01884025..16648c9b 100644 --- a/src/interfaces/IPluginManager.sol +++ b/src/interfaces/IPluginManager.sol @@ -6,6 +6,7 @@ pragma solidity ^0.8.22; +// Treats the first 20 bytes as an address, and the last byte as a function identifier. type FunctionReference is bytes21; /// @title Plugin Manager Interface diff --git a/src/interfaces/IStandardExecutor.sol b/src/interfaces/IStandardExecutor.sol index bc8eecf5..4bdda531 100644 --- a/src/interfaces/IStandardExecutor.sol +++ b/src/interfaces/IStandardExecutor.sol @@ -9,7 +9,7 @@ pragma solidity ^0.8.22; struct Call { // The target address for the account to call. address target; - // The value sent with the call. + // The value to send with the call. uint256 value; // The calldata for the call. bytes data; @@ -20,7 +20,7 @@ interface IStandardExecutor { /// @notice Standard execute method. /// @dev If the target is a plugin, the call SHOULD revert. /// @param target The target address for the account to call. - /// @param value The value sent with the call. + /// @param value The value to send with the call. /// @param data The calldata for the call. /// @return The return data from the call. function execute(address target, uint256 value, bytes calldata data) external payable returns (bytes memory);