From 7593d207871afd7c03000b93fdde7955d09d4d5c Mon Sep 17 00:00:00 2001 From: Alex Laird Date: Thu, 31 Oct 2024 09:24:54 -0500 Subject: [PATCH] Don't allow input params from GitHub actions, forks can define their own secret to run. --- .github/workflows/integration.yml | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index bcb302d..eefeef4 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -3,16 +3,6 @@ name: Integration Test on: workflow_call: workflow_dispatch: - inputs: - AMAZON_USERNAME: - type: string - description: Amazon username of account to run tests against - AMAZON_PASSWORD: - type: string - description: Amazon password of account to run tests against - TO_PHONE_NUMBER: - type: string - description: Phone number to which 2FA login codes will be sent schedule: - cron: "0 17 * * 1" @@ -22,13 +12,13 @@ jobs: env: FORCE_COLOR: 1 - AMAZON_USERNAME: ${{ inputs.AMAZON_USERNAME || secrets.AMAZON_USERNAME }} - AMAZON_PASSWORD: ${{ inputs.AMAZON_PASSWORD || secrets.AMAZON_PASSWORD }} + AMAZON_USERNAME: ${{ secrets.AMAZON_USERNAME }} + AMAZON_PASSWORD: ${{ secrets.AMAZON_PASSWORD }} START_INDEX_FULL_HISTORY: ${{ vars.START_INDEX_FULL_HISTORY }} TWILIO_ACCOUNT_SID: ${{ secrets.TWILIO_ACCOUNT_SID }} TWILIO_AUTH_TOKEN: ${{ secrets.TWILIO_AUTH_TOKEN }} TWILIO_PHONE_NUMBER: ${{ secrets.TWILIO_PHONE_NUMBER }} - TO_PHONE_NUMBER: ${{ inputs.TO_PHONE_NUMBER || secrets.TO_PHONE_NUMBER }} + TO_PHONE_NUMBER: ${{ secrets.TO_PHONE_NUMBER }} NGROK_AUTHTOKEN: ${{ secrets.NGROK_AUTHTOKEN }} runs-on: ubuntu-latest