Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for international Amazon sites #15

Open
3 tasks done
NicolasP opened this issue Apr 10, 2024 · 3 comments
Open
3 tasks done

Support for international Amazon sites #15

NicolasP opened this issue Apr 10, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed wip Work in progress, will be ignored by stale bot

Comments

@NicolasP
Copy link

Acknowledgements

  • I have written a descriptive issue title
  • I have searched Issues to see if the feature has already been requested
  • If relevant, I have enabled debug mode and am attaching relevant console logs and HTML files

Describe the Feature

The code is only compatible with Amazon US.
It would be really nice to make it possible to use it on international Amazon sites.

Describe Alternative Solutions/Workarounds

Setting AMAZON_BASE_URL is not sufficient, because the parsing code expects English text and US Dollar amounts.

@NicolasP NicolasP added the enhancement New feature or request label Apr 10, 2024
@alexdlaird
Copy link
Owner

This is a known limitation of the library and called out in the README, but I would gladly accept a PR to add international support! I added the AMAZON_BASE_URL configurability because that at least allows you to use amazon.co.uk, or other English-based international sites. But yes, support for other languages and currencies would be appreciated. I do not have the expertise or proficiency to implement the parsing for that, but would love to make this a more collaborative library.

@alexdlaird alexdlaird added the help wanted Extra attention is needed label Apr 10, 2024
Copy link

This issue is stale because it has remained open with no further activity on it. Comment with additional context or the issue will be closed automatically. Thank you for your contribution!

@github-actions github-actions bot added the stale Issue will be closed automatically if no further activity occurs label Apr 18, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
@alexdlaird alexdlaird added wip Work in progress, will be ignored by stale bot and removed stale Issue will be closed automatically if no further activity occurs labels May 12, 2024
@alexdlaird alexdlaird moved this from Triage to Ready in @alexdlaird's Traige Board May 12, 2024
@alexdlaird alexdlaird reopened this May 18, 2024
@github-project-automation github-project-automation bot moved this from Ready to Triage in @alexdlaird's Traige Board May 18, 2024
@alexdlaird
Copy link
Owner

alexdlaird commented May 18, 2024

I do not plan on implementing additional regionalizations myself, as this ticket requests, but what I do plan on doing is eliminating constants.py and replacing it with a proper localization implementation, probably an interface with an install() that defaults to en-US. Support for a basic config file where you can update your preferred localization then would also be supported. Then others can submit PRs to add additional localizations, and once merged, any user will be able to install that locale via the config file.

I have yet landed on how exactly I'm going to approach this, I'm considering gettext() (or similar, gettext might be overkill for what we need). Reopened this issue as a placeholder for this work.

@alexdlaird alexdlaird moved this from Triage to Ready in @alexdlaird's Traige Board May 21, 2024
@alexdlaird alexdlaird moved this from Ready to In progress in @alexdlaird's Traige Board May 21, 2024
@alexdlaird alexdlaird mentioned this issue Jan 8, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wip Work in progress, will be ignored by stale bot
Projects
Status: In progress
Development

No branches or pull requests

2 participants