-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asyncio support? #19
Comments
No plans to add this, but would be happy to consider a pull request. It doesn't seem like it'd be a huge lift, and the current tests for unit / integration should catch any regressions. |
If anyone does pick this up to do it, I think I'd rather switch ot using The biggest lift beyond this will probably be refactoring tests, which currently very conveniently uses Once the coupling with AmazonSession is replaced, the remaining code to add |
For httpx there is pytest_httpx Would you want both sync and async support, or are you ok with dropping sync altogether? |
Nice! I think we'd want to maintain both, but I haven't thought about it enough to decide if users would lose anything they might miss if we dropped sync support ... I'll noodle on it, would be curious to know your thoughts. |
Acknowledgements
debug
mode and am attaching relevant console logs and HTML filesDescribe the Feature
Would you be open to adding asyncio support using either httpx or aiohttp?
might help speed up loading as it is currently pretty slow.
Describe Alternative Solutions/Workarounds
Other options are using something like gevent maybe? But asyncio seems cleaner.
The text was updated successfully, but these errors were encountered: