Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Big Sur crash #63

Open
jslegendre opened this issue Aug 18, 2020 · 36 comments
Open

Fix for Big Sur crash #63

jslegendre opened this issue Aug 18, 2020 · 36 comments

Comments

@jslegendre
Copy link

In TKMutableAssetStorage.m add:

- (BOOL)caAllowSubimageOfImage:(CGImageRef)image {
    return YES;
}
@ghost
Copy link

ghost commented Aug 20, 2020

Thanks!
I've been unable to figure that out myself. I would build ThemeEngine and eventually get an NSException and TKMutableAssets would always be there as an error.

Should be fun trying on Big Sur now.

Hmm - didn't quite work as expected for me. Have you made it compile and being able to open a .car file and not just the Welcome window?

@jslegendre
Copy link
Author

Yes, I can open/browse .car files with this. Is it still crashing for you?

@ghost
Copy link

ghost commented Aug 20, 2020

Yes,

I get this:
libsystem_kernel.dylibmach_msg_trap:
0x7fff6d98bf64 <+0>: movq %rcx, %r10
0x7fff6d98bf67 <+3>: movl $0x100001f, %eax ; imm = 0x100001F
0x7fff6d98bf6c <+8>: syscall
-> 0x7fff6d98bf6e <+10>: retq
0x7fff6d98bf6f <+11>: nop
`

the -> 0x7fff6d98bf6e <+10>: retq has a green description that reads Thread 1: signal SIGCONT

@jslegendre
Copy link
Author

Sounds like you have a breakpoint set... Try running ThemeEngine without Xcode

@ghost
Copy link

ghost commented Aug 20, 2020

Much better ! :D Thanks. Now I can get to see what changes I can make to Big Sur. There are so many .car files that needs some finding out this time around

@ghost
Copy link

ghost commented Aug 20, 2020

Too bad that I can't save any .car files on Big Sur... I installed Big Sur using csrutil authenticated-root disable and csrutil disable - that still hasn't made a difference. I also mounted( I think) all the volumes and changes permissions on the .car file I want to change. Yet, ThemeEngine doesn't respond to Save commands. Perhaps adding ThemeEngine to the Full Disk Access list would help. Edit.. no, didn't help adding ThemeEngine to the Full Disk Access list.

@jslegendre
Copy link
Author

Try restarting Finder. In terminal type killall Finder

@yonigold1
Copy link

yonigold1 commented Aug 28, 2020

In TKMutableAssetStorage.m add:

- (BOOL)caAllowSubimageOfImage:(CGImageRef)image {
    return YES;
}

Would someone be able to build it to an app for me with that change as I am only a graphic designer and editing/building an app is a whole new world for me. it would be greatly appreciated 👉👈

@yonigold1
Copy link

Would someone be able to compile it for me?

@jslegendre
Copy link
Author

@yonigold1
I have made a fork of this project and included a notarized release.
https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K
My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now.
https://github.com/jslegendre/ThemeEngine

@ghost
Copy link

ghost commented Sep 6, 2020

@jslegendre Thanks! I see that you mention that Receive from Editor is working again.

@mbert and I spoke about(didn't get any further) multiple Send to Editor and the same for Receive from Editor back when he initially pulled in my before-mentioned "non-fixes" to the way of enumerating assets and the silly scrolling.
Examples such as;
Send to Sketch
Send to Affinity Photo
Send to Affinity Designer

And of course the usual Adobe entries. Send to Editor worked fine but I seem to remember it taking Affinity Photo only and not Designer - if both were installed.
Receive from Editor never worked despite all my attempts in re-writing some of the script handling the AppleScript sending and receiving.
I would think Acorn 6 would have full scripting, but I never got that far myself.

Great seeing Receive from Editor working again.

Thank you for the detailed explanation on Big Sur read/write access. I hope @alexzielenski sees this.

@yonigold1
Copy link

Hey so I just want to thank you for doing that!!!
and just a little issue I noticed in the app is that it doesn't save any of the edits I made to the .car file I've tried multiple times and can't seem to get it to work

@yonigold1
I have made a fork of this project and included a notarized release.
https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K
My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now.
https://github.com/jslegendre/ThemeEngine

@jslegendre
Copy link
Author

@yonigold1 I was getting that problem too but seemed to depend on the file and what edits were made.
Issue has been fixed, check out the latest release

@yonigold1
Copy link

yonigold1 commented Sep 7, 2020

im still expeirencing the issue so here let me get at what im trying to do/theme because maybe that can help to fix it.
So im trying to theme the Domino's app on iOS because it looks like it was made for iOS 6. So the very first thing i tried to change was the app background but it doesnt seem to save. ill attach the assets.car so you can try your self (im just replacing the background with a white image)
Assets.zip

@jslegendre
Copy link
Author

@yonigold1 Yep, seems to be a problem with .jpg assets because the png files I tried worked fine. Will continue to investigate.

@yonigold1
Copy link

thank you so much for your time i really appreciate it !

@ghost
Copy link

ghost commented Sep 8, 2020

@jslegendre How come the names in the sidebar list are truncated? It's not a major issue as I can quickly find out what's what. What's your thought on my suggestions with having multiple Send to Editor and Receive from Editor? Currently I of course can't use any of these commands as they depend on Adobe's apps.

@jslegendre
Copy link
Author

@yonigold1
Turns out the issue was a little more complicated than I thought it would be but it's fixed now.

@MUI68K
I will be switching to Sketch for sending/receiving

@hatsune-miku
Copy link

Thank you!

@mbert
Copy link
Contributor

mbert commented Nov 13, 2020

@yonigold1
I have made a fork of this project and included a notarized release.
https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K
My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now.
https://github.com/jslegendre/ThemeEngine

Thank you very much for this! Since there's no "issues" section in your fork, is it possible to re-enable SIP after having replaced .car files? On Catalina I would usually boot into maintenance mode after my modification and run csrutil enable, so would I do csrutil authenticated-root enable; csrutil enable on Big Sur when done? Or can't I because after my modification the system volume is no longer original?

@jslegendre
Copy link
Author

jslegendre commented Nov 13, 2020

Or can't I because after my modification the system volume is no longer original?

I believe that is the case. You may be able to have authenticated-root disabled with normal SIP enabled but I haven’t tried

@mbert
Copy link
Contributor

mbert commented Nov 13, 2020

Thank you. Since Apple is making theming increasingly difficult I am tempted to leave my .car files alone for now. Overall the OS doesn't look bad. Only the 2d traffic light buttons bother me.

@nsklaus
Copy link

nsklaus commented Nov 23, 2020

would it be possible to use this project to restore macOS theme to what it was prior to the Big Sur update ? possibly take all the car files from a previous release (Catalina) and apply them to Big Sur ? I really dislike the new cosmetic changes apple have done. especially the window title bar height, tool bar and tool bar icons. that flat design is bad.

@yonigold1
Copy link

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

@grafikartes
Copy link

grafikartes commented Nov 27, 2020

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

@ghost
Copy link

ghost commented Nov 27, 2020

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

Exactly !

@quangka
Copy link

quangka commented Nov 28, 2020 via email

@quangka
Copy link

quangka commented Nov 28, 2020 via email

@quangka
Copy link

quangka commented Nov 28, 2020 via email

@ghost
Copy link

ghost commented Nov 28, 2020

@quangka

Is it possible to program themeEngine to work on Ios?

You can edit the iOS .car files by extracting them from iOS onto the Mac and then edit using ThemeEngine.
This all requires Jailbreaking you iOS device from what I've heard.

I'm not certain if there's any plans on bringing ThemeEngine over to iOS.

@quangka
Copy link

quangka commented Nov 28, 2020 via email

@quangka
Copy link

quangka commented Nov 28, 2020 via email

@ghost
Copy link

ghost commented Nov 28, 2020

@quangka What's the error you're getting?
Are you using macOS Big Sur or macOS Catalina?

You might have to use a different build of ThemeEngine for when on macOS Catalina. I can help with that.

@yonigold1
Copy link

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

It still wont work for me

@ghost
Copy link

ghost commented Nov 29, 2020

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

It still wont work for me

Have you done all the steps for editing .car files on Big Sur as described on the page here ?
https://github.com/jslegendre/ThemeEngine/blob/v3/README.md

I initially faced the same issue until I learned the correct way on how to edit the files.

@tcptps
Copy link

tcptps commented Feb 9, 2021

Or can't I because after my modification the system volume is no longer original?

I believe that is the case. You may be able to have authenticated-root disabled with normal SIP enabled but I haven’t tried

MAIN QUESTION
Has any body tried this yet ?

Side Questions:
Am I right on those assumptions ?
And is it mandatory to disable because I use FileVault and it currently won’t let me disable authenticated-root because of it. YES it is !
Does anybody know FileVault works at all with authenticated-root disabled ? NO! but YES on T2 ?
Post about authenticated-root
A Thread about It
And another Thread
Any help is very much appreciated.

Something I didn’t understand but seems useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants