Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging setup on import #7

Open
jamylak opened this issue Feb 21, 2021 · 2 comments
Open

Logging setup on import #7

jamylak opened this issue Feb 21, 2021 · 2 comments
Labels
question Further information is requested

Comments

@jamylak
Copy link
Contributor

jamylak commented Feb 21, 2021

eg.

https://github.com/ambiata/atmospherex/blob/master/atmospherex_activity_base/atmospherex_activity_base/__init__.py
https://github.com/ambiata/atmospherex/blob/master/atmospherex_activity_base/atmospherex_activity_base/logger_setup.py

Why did we have it like this? What is the goal?

It was causing me some issues so I temporarily commented it out.
@jamylak jamylak added the question Further information is requested label Feb 21, 2021
@gusmith
Copy link
Contributor

gusmith commented Feb 22, 2021

The goal is just to setup the logging. If it causes issue, let's find another way.

@gusmith gusmith removed their assignment Feb 24, 2021
@jamylak
Copy link
Contributor Author

jamylak commented May 20, 2021

@gusmith I'm not sure if this is fixed in the new sdk, can you please verify it is logging as expected now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamylak @gusmith