Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-11 through clang-16 fail to install on ubuntu-24.04 #329

Closed
KrystalDelusion opened this issue Jan 19, 2025 · 4 comments · Fixed by #331
Closed

clang-11 through clang-16 fail to install on ubuntu-24.04 #329

KrystalDelusion opened this issue Jan 19, 2025 · 4 comments · Fixed by #331
Labels
bug Something isn't working

Comments

@KrystalDelusion
Copy link

When trying to install clang-11 through clang-16 on ubuntu-24.04 it looks like it's trying to install from source, and as part of that attempts to install libtinfo-dev which is not available in distros newer than jammy (22.04). For clang<=10 it looks like there it uses libtinfo5 which has a valid fallback.

Should it be changed to install libtinfo6 for clang>10? That is available on noble (24.04), while libtinfo-dev on jammy says

This is a transitional package that can safely be removed.

@aminya aminya added the bug Something isn't working label Jan 20, 2025
@aminya
Copy link
Owner

aminya commented Jan 20, 2025

Thanks for the report. Do you have logs for this that could speed up the debugging?

@KrystalDelusion
Copy link
Author

KrystalDelusion commented Jan 20, 2025

https://github.com/KrystalDelusion/yosys/actions/runs/12857796412 has a step:

      - name: Setup Cpp
        uses: aminya/setup-cpp@v1
        with:
          compiler: ${{ matrix.compiler }}

Which I ran with clang-10 through clang-19 under ubuntu-latest (instanced as 24.04).
It gives the following for the failing builds:

Error: Failed to install apt packages: Command failed with exit code 100: sudo 'apt-get' 'update' '-y' '-o' 'Dpkg::Lock::Timeout=300'
Error: Command failed with exit code 100: sudo 'apt-get' 'update' '-y' '-o' 'Dpkg::Lock::Timeout=300'
    at Vi (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:208894)
    at b (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:26442)
    at file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:29976
    at A (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:29985)
    at file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:254203
    at Gc.T (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:43819)
    at ot (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:112896)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:112095
    at async rt (file:///home/runner/work/_actions/aminya/setup-cpp/v1/dist/modern/setup-cpp.mjs:2:112060)

@aminya
Copy link
Owner

aminya commented Jan 20, 2025

Thanks. We can fix this by removing the non-existent LLVM ppa after the failed installation.

info(`Failed to install llvm via system package manager ${err}`)

Then installation will fallback to the normal binary downloads.

@aminya
Copy link
Owner

aminya commented Jan 25, 2025

I've made a PR that tries to fix this. Can you try it in your repo and see if it is fixed?

      - name: Setup Cpp
        uses: aminya/setup-cpp@llvm-remove-repo
        with:
          compiler: ${{ matrix.compiler }}

#331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants