Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampprojectbot should consider the .protoascii and .out files owned by people working on the validator #8136

Closed
powdercloud opened this issue Mar 14, 2017 · 1 comment
Assignees

Comments

@powdercloud
Copy link
Contributor

For the validator, we sync changes developed in Google's internal repo up into Github (we also sync the other direction sometimes, but that's not affected here). This is such a change:
#8134

Ampprojectbot assignes the .protoascii (validator specification files) and .out files (validator test files) to owners of the extensions. This means that getting such a sync requires many approvals, likely slowing down our process.

The solution is probably to patternmatch the protoascii and html and out files for the validator so that we can commit them even if they're in some extension directory. Thanks much for considering.

@powdercloud
Copy link
Contributor Author

Sorry about the noise - I moved this to the appropriate repo:
google/github-owners-bot#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants