Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting warnings for flex start and end #151

Open
Enivia opened this issue Jul 8, 2022 · 3 comments
Open

Not getting warnings for flex start and end #151

Enivia opened this issue Jul 8, 2022 · 3 comments

Comments

@Enivia
Copy link

Enivia commented Jul 8, 2022

  • justify-content
  • align-items

chrome 71 only support "flex-start/flex-end" value. But not getting warnings.

@WebMechanic
Copy link

@Enivia about 40 versions later, this should no longer be an issue :D
you might as well close this non-issue :)

@clshortfuse clshortfuse added the bug label Jul 5, 2023
@clshortfuse
Copy link
Collaborator

There's some newer caniuse links for this but it seems some align-* properties are no longer checked.

Regression from: a51556f#diff-ce96c1428056addae5c99b04be7bf60109c8e048dc3bc8ac610bd65f79aa1bbaL13

Seems the old test was removed as well:

a51556f#diff-f3db8bc9b4c249db92b37c4be54c044dfa31b54911db9e91c4ea770cd1bc177f

It seems like the regression from the commit.

@RJWadley Can you confirm the regression? I don't think this is affected by the pending partial support PR.

@RJWadley
Copy link
Contributor

RJWadley commented Jul 5, 2023

Yeah, if I recall correctly those properties apply to both CSS flex and CSS grid, and so detecting them is not as simple. Would have to do a more involved check to catch those again.

The gap property has a check like that, and it could probably be applied here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants