Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinGW Build failed #451

Open
Mentent opened this issue Jan 12, 2019 · 2 comments
Open

MinGW Build failed #451

Mentent opened this issue Jan 12, 2019 · 2 comments

Comments

@Mentent
Copy link

Mentent commented Jan 12, 2019

That is strange! I've tried to build it in many different ways(including the manifest) but that doesn't work.
image
@franko
Copy link

franko commented Jan 12, 2019

Hi,

I stumbled in the same problem. I made a pull request to fix this problem:

#436

but it was not accepted. The right solution is to include a manifest file as suggested here:

#436 (comment)

@andlabs
Copy link
Owner

andlabs commented Jan 12, 2019

What I don't understand is the nature of that error. I forget what version of comctl32 InitCommonControlsEx() was introduced in, and if it was 6, why your program was allowed to run even without the manifest.

andlabs added a commit that referenced this issue Apr 21, 2019
@andlabs
Pruned windows/init.cpp to a minimal initialization that we can test …
c6aa8c3 
…things with, which includes adding a function to load err->Message with a formatted string.

Also added a better error for if InitCommonControlsEx() returns 0 without setting the last error; this usually means that v5 is loaded.
Fixes #451.
Updates #337.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@franko @andlabs @Mentent