From 97c16a2fc52f114781ac8132f5efa02eef3dea6e Mon Sep 17 00:00:00 2001
From: Georgios Kalpakas <g.kalpakas@hotmail.com>
Date: Fri, 18 Mar 2016 19:57:37 +0200
Subject: [PATCH] fix(hint): properly clean up when location is changed before
 DOM content has been loaded

The `beforeunload` event was never fired if the location was changed before the DOM content had
been loaded (e.g. directly inside a `<script>` tag). The `unload` event is fired more consistently.
This commit listens for both events to cover more potential browser bugs/edge-cases.

Fixes angular/batarang#290
---
 hint.js | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/hint.js b/hint.js
index 340b0682..b249ceda 100644
--- a/hint.js
+++ b/hint.js
@@ -46,19 +46,26 @@ if (deferRegex.test(window.name)) {
 }
 //If this is not a test, defer bootstrapping
 else {
+  var isDeferLabelRemoved = false;
   window.name = DEFER_LABEL + window.name;
 
   // determine which modules to load and resume bootstrap
   document.addEventListener('DOMContentLoaded', maybeBootstrap);
 
-  /* angular should remove DEFER_LABEL from window.name, but if angular is never loaded, we want
-   to remove it ourselves, otherwise hint will incorrectly detect protractor as being present on
-   the next page load */
-  window.addEventListener('beforeunload', function() {
-    if (deferRegex.test(window.name)) {
+  // AngularJS should remove `DEFER_LABEL` from `window.name`, but if AngularJS is never loaded,
+  // we want to remove it ourselves. Otherwise `hint` will incorrectly detect protractor as being
+  // present on the next page load.
+  // Generally, the `unload` event is fired more consistently, but we also use `beforeunload` to
+  // cover potential browser bugs/edge-cases.
+  window.addEventListener('unload', removeDeferLabelOnce);
+  window.addEventListener('beforeunload', removeDeferLabelOnce);
+
+  function removeDeferLabelOnce() {
+    if (!isDeferLabelRemoved && deferRegex.test(window.name)) {
       window.name = window.name.substring(DEFER_LABEL.length);
+      isDeferLabelRemoved = true;
     }
-  });
+  }
 }
 
 function maybeBootstrap() {