-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brilliant project, Feature request? #1
Comments
let toast = Vue.$toast.open('You did it!');
// dismiss
toast.close();
Yes, We can use slots for template customisation.
What are the other actions?
I am not interested in learning any foreign language. (Not being rude)
We can use vue event bus for it. I am open to receive PR for slots and event bus. |
I wouldn't replace JS with TypeScript, if that's what you were wondering. I was just talking about adding type definition files so that people using TypeScript can use it easier. If you'd prefer not, then I won't submit it to you. Instead, I may end up adding type definitions to the DefinitelyTyped project. I do this because my company does use TypeScript. Slots would mean a slight change in implementation, and upon reflection, it may not be the best fit. We could potentially do a template system, but that starts to get complicated and would possibly require shipping with the compiler, which would make most apps bloated. More discussion would be necessary before we could do that. |
I would prefer DefinitelyTyped project as separate package that you owns. Regarding slots: I am thinking of these slots:
|
Follow #17 |
So I think that this project is great! It's simple and straightforward, too. However, there are a few things that I feel could be good features on top of what's already implemented.
Are any of these on the radar? The TypeScript support shouldn't be hard to create, and I've created what should work for dismissing all of the components (though it's using a property on an element that likely isn't supposed to be used for non-Vue-core code to access a component instance). Would you appreciate PRs for some of these suggestions?
The text was updated successfully, but these errors were encountered: