Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic settings may fail when slice involving #36

Open
RocFang opened this issue Jan 27, 2022 · 3 comments
Open

dynamic settings may fail when slice involving #36

RocFang opened this issue Jan 27, 2022 · 3 comments
Labels
note Something important

Comments

@RocFang
Copy link

RocFang commented Jan 27, 2022

Hello! @spacewander

Since https://hg.nginx.org/nginx/rev/d16ba0ea3434
Subrequests of slice module will bypass phases which come before content handler, and may trigger some confusing behaviors for some dynamic settiings, especialy proxy settings. For example #35 .

The safe way maybe set the according attributes of ngx_http_apisix_ctx_t again to ctx->sr right after ngx_http_subrequest in ngx_http_slice_filter_module.c .

It's not a bug report, just a mention.

@spacewander
Copy link
Contributor

Thanks for your suggestion!

@spacewander spacewander added the note Something important label Jan 27, 2022
@membphis
Copy link

many thx for your nice mention @RocFang

@RocFang
Copy link
Author

RocFang commented Jan 27, 2022

@membphis It's a pleasure. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note Something important
Projects
None yet
Development

No branches or pull requests

3 participants