Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on executing Fluid3d initialization scripts. #287

Open
TheAndiKurz opened this issue Oct 18, 2024 · 2 comments
Open

Error on executing Fluid3d initialization scripts. #287

TheAndiKurz opened this issue Oct 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@TheAndiKurz
Copy link

TheAndiKurz commented Oct 18, 2024

Describe the bug

After installing:
When attaching the addons/godot-rapier3d/fluid_3d_box.gd script onto a Fluid3D Node and changing the values of the script it should create the meshes in the Editor and they should be seen.

But for I got an error when changing any value of the script.
Script Error

To Reproduce

Steps to reproduce the behavior:

  • Create a Godot Project
  • Select Node3D as your scene root
  • Install Godot Rapier Physics (fast SIMD) Getting Started
  • Create a Fluid3D Node as child of the root Node3D
  • Create a FluidRenderer and select Fluid3D
  • Drag the script in addons/godot-rapier3d called fluid_3d_box.gd onto the Fluid3D node
  • Select the Fluid3D Node
  • Change the Value of height, width or depth
    image

Expected behavior

When I change any of the values of the script I expect that in the editor multiple spheres show up in a grid that is 10x10x10 (values in the script of Fluid3D).

I expected all the spheres to be normally distributed (same distance between them).

As it also shows the spheres, when creating them directly in the Fluid3D points property.

Environment:

  • OS: Linux Ubuntu 24.04.1 LTS
  • Version: v0.8.7
  • Godot Version: v4.3
  • Type: simd 3d single

Example project(zip)

Please attach a zip with project where issue occurs. Remove the addons folder so that the size is less than 25 mb.

rapier-fluid-bug.zip

@TheAndiKurz TheAndiKurz added the bug Something isn't working label Oct 18, 2024
@Ughuuu
Copy link
Contributor

Ughuuu commented Oct 31, 2024

I think a better option for this would be to add an editor plugin button in the 2d/3d scene view instead of a script.

@Ughuuu Ughuuu added enhancement New feature or request and removed bug Something isn't working labels Jan 1, 2025
@Ughuuu
Copy link
Contributor

Ughuuu commented Jan 1, 2025

So instead of bug, I would call this enchancement, and we should try to do it in an editor plugin. That means those .gdscripts that are offered and the create_box_points should be reimplemented as a editor plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants