-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Remove ?si=xxx param in shared urls #96
Comments
That’s new. I never seen a url with ?si=xxx |
Yeah, I first noticed it yesterday. |
Hey I think I found a workaround for your problem. Go to |
Nice. I just went to turn it on, and I already have it on. I guess I just never used it (I instead use the share button under the video). |
I just made this recently
I found a possible cause I think. Next Release this will be implemented to help remove some of these parameters around the app. |
That's amazing! (Also, why does youtube use NO instead of false?) |
well I have no clue. it’s just a different code format and btw I’m not finished with the code above. There are more tracking params that I gotta find around the app in order to make it work correctly. |
This is kinda related to this qnblackcat#1178, if you could do these too that'd be great! |
the new tweak YTNoTracking is basically YTNoStripping and I did attempt to remove the ?si=xx param in shared urls using NSURL but failed to have the knowledge to do that right. |
Any progress on this? |
I’m trying, I did try to use |
Sorry to bother, but any progress? |
I completely forgot about this, but the progress wasn’t really there. But wait. There is a workaround that can be used. |
Next release, I will include a new button RPReplay_Final1716691127.mp4Special Thanks to bhackel for helping out with it! |
That's cool! But since this is possible, I wonder if can you just hide the share button and then make add in your own share button that would get the link from the YouTube video without the tracking parameter and then send it straight to the iOS style share sheet also incorporating a direct native iOS share sheet. |
It’s possible. I have the code to add the button in thanks to NguyenASang but there would be an issue. It would overlap PoomSmart’s |
Found this tweak, that not only removes the "si" URL parameter, but also forces the native iOS share sheet, if you could implement the code from here in two options, one to remove the "si" parameter and one to bypass the YouTube share sheet... that'd be amazing it possible. |
I was about to implement something to filter it out but seeing this tweak made me realize mine wouldn’t had worked. I will definitely implement this. Thanks Yodaluca23! |
Hey, since this commit, 59cc391 the share button just completely doesn't work... I think something was implemented wrong... Also, I couldn't find a switch in settings, is their supposed to be, or is it just not going to be controllable? |
You are correct. It was implemented wrong. I removed the 2 lines of unnecessary code in the new commit 95477c6 |
Yep, can confirm it works now! Thank you so much, this is going to save me so much time manually stripping it! 😃 |
It was planned on being an option aswell but not sure if I should go forward with it |
I have reopened the issue, although it does work but however on iPad Devices it doesn’t use the system share sheet or sanitize the url. Possible Workaround1. Search for “iPhone Layout” and enable it in uYouEnhanced. ALT. Copy the key to the clipboard below and enable it using Paste Settings in uYouEnhanced.
Edit: it’s fixed in v0.1.0. |
Have you read the FAQ?
Is there an existing issue/question for this?
Do you think this is a bug?
❌ No, I don't think this is a bug. I will explain below
My question
I noticed that youtube started adding an ?si=xxx param to the end of urls when sharing a video / playlist. This is most likely tracking info, because it's not necessary. It would be great if there was an option to sanitize links, removing unnecessary url params from shared links.
Additional context
Here's an example url
https://youtu.be/zrQldlvovhc?si=4WMQXL9YX3jG9kT6
This makes urls longer, and takes more time for users to remove the tracking param, so it would be nice if there was an option to remove these.
The text was updated successfully, but these errors were encountered: