Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how to add sun.net and com.sun.net packages #77

Open
lordofthejars opened this issue Jul 3, 2017 · 2 comments
Open

Investigate how to add sun.net and com.sun.net packages #77

lordofthejars opened this issue Jul 3, 2017 · 2 comments

Comments

@lordofthejars
Copy link
Member

lordofthejars commented Jul 3, 2017 •
edited
Loading

Currently we are adding one by one classes required by Pact from package sun.net and com.sun.net, cannot use ShirnkWrap packages method because rt.jar was packaged without the directory entries (Full description here #76) so we need to figure out if there is a better way of doing this instead of adding one by one.

Class that needs to be improved is https://github.com/arquillian/arquillian-algeron/blob/master/pact/consumer/core/src/main/java/org/arquillian/algeron/pact/consumer/core/client/PactConsumerArchiveAppender.java
@bartoszmajsak
Copy link
Member

The description is wrong. Please read my comments in the closed PR.

@lordofthejars
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartoszmajsak @lordofthejars