Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: merge_csv uses last however that might mean a reduction in number of clones / traffic views #97

Open
astrochun opened this issue Aug 17, 2022 · 0 comments
Open

Bug: merge_csv uses last however that might mean a reduction in number of clones / traffic views #97

astrochun opened this issue Aug 17, 2022 · 0 comments
Assignees
@astrochun
Labels
bug Something isn't working scripts

Comments

@astrochun
Copy link
Owner

In general, we wish to keep the highest count. Depending on when the schedule CI runs, this might truncate data for the earliest date. merge_csv uses a drop_duplicates approach. That is not as ideal with keep=last.

Some filtering is needed to keep the one with the highest value.
@astrochun astrochun added bug Something isn't working scripts labels Aug 17, 2022
@astrochun astrochun self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
bug Something isn't working scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astrochun