Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues with Python 3.8 #27

Closed
kiranzo opened this issue Aug 23, 2024 · 4 comments
Closed

Compatibility issues with Python 3.8 #27

kiranzo opened this issue Aug 23, 2024 · 4 comments
Assignees

Comments

@kiranzo
Copy link

kiranzo commented Aug 23, 2024

requirements.txt say "streamerate>=1.0.0", but latest version is not compatible with python 3.8 due to it using Python 3.10 syntax.

@asuiu asuiu self-assigned this Aug 26, 2024
@asuiu
Copy link
Owner

asuiu commented Aug 26, 2024

Fixed in this commit: 594dfc5
Built & deployed new version on PyPi: https://pypi.org/project/pyxtension/1.16.11/

Also feel free to raise PRs.

@kiranzo thanks for contributing and creating issues!

Feel free to check and come back if it doesn't fix the issue

@asuiu asuiu closed this as completed Aug 26, 2024
@kiranzo
Copy link
Author

kiranzo commented Aug 26, 2024

@asuiu Fixed, thanks!
Problem is, I came across this error trying to use bintablefile library, and I still can't get it to work each time for different reason! Guess I'll just use gzipped parquet for my table data.

@asuiu
Copy link
Owner

asuiu commented Aug 27, 2024

@asuiu Fixed, thanks! Problem is, I came across this error trying to use bintablefile library, and I still can't get it to work each time for different reason! Guess I'll just use gzipped parquet for my table data.

@kiranzo
Just curious what errors you've got with the bintablefile. Feel free to add an issue on the project's github page, will be glad to try fix the usecase.

As a side note, instead of Parquet, I found ORC format slightly more friendly for the Python ecosystem.
Also avoid applying the GZip over the Parquet/ORC, as these formats are performing internal compression AFAIK, and performance can degrade if compression is applied over the whole file (i.e. headers and metadata)

@kiranzo
Copy link
Author

kiranzo commented Aug 27, 2024

@asuiu Fixed, thanks! Problem is, I came across this error trying to use bintablefile library, and I still can't get it to work each time for different reason! Guess I'll just use gzipped parquet for my table data.

@kiranzo Just curious what errors you've got with the bintablefile. Feel free to add an issue on the project's github page, will be glad to try fix the usecase.

As a side note, instead of Parquet, I found ORC format slightly more friendly for the Python ecosystem. Also avoid applying the GZip over the Parquet/ORC, as these formats are performing internal compression AFAIK, and performance can degrade if compression is applied over the whole file (i.e. headers and metadata)

eSAMTrade/bintablefile#6

I created it today. Thanks for the ORC suggestion, I'll look into it. Also, I created my parquet.gz with Pandas compression options, so it should be ok.
I test everything on a table that has uuid, filepath and 3 categorical columns (they were enums in PostgreSQL), so bintablefile doesn't suit my needs, unless I convert PostgreSQL enums to int-backed Python enums (we discussed it today, but it's something to consider in the future for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants