Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Connect Wallet details via the Browser Extension (key, phrases) #78

Open
ozgunozerk opened this issue Mar 10, 2022 · 2 comments
Open

Connect Wallet details via the Browser Extension (key, phrases) #78

ozgunozerk opened this issue Mar 10, 2022 · 2 comments
Assignees
Labels
improvement it is already working, but can be better
Milestone

Comments

@ozgunozerk
Copy link
Contributor

ozgunozerk commented Mar 10, 2022

We are not storing the mnemonic for security purposes, but we can encrypt it using the user-password.
This could be the default option, and not storing the mnemonic could be an advanced option.

If we decide to store the mnemonic, we should be able connect it to a wallet


Feature: Connect Wallet details via the Browser Extension

I want to be able to fetch my wallet details through my wallet browser extension.
The desktop application should navigate to open my wallet on the browser, which should
be able to sync the wallet details it needs. For security purpose, we want protect those 
details and not store it.

Example: 
  As a Desktop App User
  Given I have a wallet extension
  And I want to fetch the details
  When I click the connect button
  Then It should open up a browser
  And ask to fetch my wallet details.
@1devNdogs 1devNdogs added improvement it is already working, but can be better next-iteration labels Mar 10, 2022
@ozgunozerk ozgunozerk moved this from Todo to Not Decided Yet in Product Engineering Mar 28, 2022
@ozgunozerk ozgunozerk moved this from Not Decided Yet to Blocked in Product Engineering Mar 28, 2022
@ozgunozerk ozgunozerk added wontfix This will not be worked on and removed next-iteration labels Apr 19, 2022
Repository owner moved this from Blocked to Done in Product Engineering Apr 19, 2022
@ozgunozerk ozgunozerk reopened this Apr 21, 2022
Repository owner moved this from Done to Todo in Product Engineering Apr 21, 2022
@ozgunozerk ozgunozerk moved this from Todo to Backlog in Product Engineering Apr 21, 2022
@ozgunozerk ozgunozerk removed the wontfix This will not be worked on label Apr 28, 2022
@ozgunozerk ozgunozerk changed the title Connect mnemonic into the wallet Connect Reward Address Seed Phrase into the wallet Apr 29, 2022
@ozgunozerk ozgunozerk changed the title Connect Reward Address Seed Phrase into the wallet Connect Reward Address Seed Phrase to the wallet Apr 29, 2022
@ozgunozerk
Copy link
Contributor Author

Previously, we were storing the mnemonic of the farmer's signing key.
But now, we are only dealing with reward address on the frontend and we do not care about farmer's signing key/s.

So, this issue is about :

  • connecting the seed phrase generated on the frontend, to a wallet application.

P.S:
We should also think about importing the reward address from a wallet via a better integration in a separate issue

@rg3l3dr
Copy link
Member

rg3l3dr commented Apr 29, 2022

Look at grammarly type experience between desktop app and web app hand off.

@ozgunozerk ozgunozerk assigned isSerge and unassigned 1devNdogs May 26, 2022
@achiurizo achiurizo changed the title Connect Reward Address Seed Phrase to the wallet Allow Desktop to connect with Browser Wallet Details (key, phrases) Aug 2, 2022
@achiurizo achiurizo self-assigned this Aug 2, 2022
@achiurizo achiurizo changed the title Allow Desktop to connect with Browser Wallet Details (key, phrases) Connect Wallet details via the Browser Extension (key, phrases) Aug 9, 2022
@achiurizo achiurizo added this to the 0.7.0 milestone Nov 29, 2022
@achiurizo achiurizo removed their assignment Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement it is already working, but can be better
Projects
Status: Backlog
Development

No branches or pull requests

5 participants