Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including a add_index to allow custom index integration into workflow #34

Closed
MartinuzziFrancesco opened this issue Feb 9, 2024 · 2 comments

Comments

@MartinuzziFrancesco
Copy link
Member

currently the compute and compute_index function only work when the index is in the indices list. This makes computing custom indices kinda wonky, so the addition of a add_index function would help. This function should update the indices Dict as well as the indices_funcDict.

@MartinuzziFrancesco
Copy link
Member Author

Actually we don't need this, we can just dispatch this over a function compute_index(index::AbstractSpectralIndex, params=nothing, online::Bool=false) that works as internal call to compute_index(index::String, params=nothing, online::Bool=false)

@MartinuzziFrancesco
Copy link
Member Author

this was addressed in #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant