Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: adding text to parser docs causes pre commit errors #1445

Closed
ran-isenberg opened this issue Aug 11, 2022 · 2 comments
Closed

Bug: adding text to parser docs causes pre commit errors #1445

ran-isenberg opened this issue Aug 11, 2022 · 2 comments

Comments

@ran-isenberg
Copy link
Contributor

Expected Behaviour

docs-linter passes but pre-commit fails

Current Behaviour

docs/utilities/parser.md:586 MD043/required-headings/required-headers Required heading structure [Context: "## Getting started"]

Code snippet

(.venv) ➜  aws-lambda-powertools-python git:(func_url) ✗ make pre-commit
pre-commit run --show-diff-on-failure
Check for merge conflicts................................................Passed
Trim Trailing Whitespace.................................................Passed
Check Toml...........................................(no files to check)Skipped
formatting::black....................................(no files to check)Skipped
formatting::isort....................................(no files to check)Skipped
linting::flake8......................................(no files to check)Skipped
markdownlint.............................................................Failed
- hook id: markdownlint
- exit code: 1

docs/utilities/parser.md:586 MD043/required-headings/required-headers Required heading structure [Context: "## Getting started"]

AWS CloudFormation Linter............................(no files to check)Skipped
make: *** [pre-commit] Error 1

Possible Solution

No response

Steps to Reproduce

make pre-commit

AWS Lambda Powertools for Python version

latest

AWS Lambda function runtime

3.8

Packaging format used

PyPi

Debugging logs

(.venv) ➜  aws-lambda-powertools-python git:(func_url) ✗ make pre-commit
pre-commit run --show-diff-on-failure
Check for merge conflicts................................................Passed
Trim Trailing Whitespace.................................................Passed
Check Toml...........................................(no files to check)Skipped
formatting::black....................................(no files to check)Skipped
formatting::isort....................................(no files to check)Skipped
linting::flake8......................................(no files to check)Skipped
markdownlint.............................................................Failed
- hook id: markdownlint
- exit code: 1

docs/utilities/parser.md:586 MD043/required-headings/required-headers Required heading structure [Context: "## Getting started"]

AWS CloudFormation Linter............................(no files to check)Skipped
make: *** [pre-commit] Error 1
@ran-isenberg ran-isenberg added bug Something isn't working triage Pending triage from maintainers labels Aug 11, 2022
@heitorlessa heitorlessa removed bug Something isn't working triage Pending triage from maintainers labels Aug 11, 2022
@heitorlessa
Copy link
Contributor

Thanks Ran for the productiveness in creating an issue but that's a deliberate linting rule to ensure consistency across headings. It'll fail on updates to docs not following it.

Closing as we're tracking Parser doc refactoring on #1371

@heitorlessa heitorlessa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants