Bug: dimension value not being validated for empty strings or None

[dreamorosi]

Expected Behaviour

When adding a dimension to my metrics, I should get a warning if the dimension value is invalid aka an empty string ("") or None, and the dimension should not be added to the EMF blobs emitted by the utility.

Current Behaviour

Currently the utility doesn't validate the input and generates an EMF blob with the invalid dimension.

Code snippet

metrics = Metrics()
metrics.add_dimension("my_dim","") # THIS
metrics.add_metrics(...)
metrics.flush..

Possible Solution

We should: 1/ validate the input when adding a dimension, 2/ emit a warning if invalid, and 3/ don't add the dimension to the EMF blob

Steps to Reproduce

1. Run the code above
2. Observe that the EMF blob emitted has an empty dimension
3. Verify that the processed metric in CloudWatch does not include any dimensions

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.8

Packaging format used

PyPi

Debugging logs

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

[github-actions]

This is now released under 3.3.0 version!