Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConversionSchemas should also consider annotation DynamoDBTypeConverted besides the now deprecated DynamoDBMarshalling #2144

Closed
tungpham opened this issue Nov 8, 2019 · 2 comments
Closed

ConversionSchemas should also consider annotation DynamoDBTypeConverted besides the now deprecated DynamoDBMarshalling #2144

tungpham opened this issue Nov 8, 2019 · 2 comments
Assignees
@debora-ito
Labels
feature-request A feature should be added or improved.

Comments

@tungpham
Copy link

tungpham commented Nov 8, 2019

If @DynamoDBMarshalling is marked as deprecated, then you should also take the recommended @DynamoDBTypeConverted into account as well. Currently, there's no way to add @DynamoDBTypeConvertedJson to the unmarshallerSet

https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-dynamodb/src/main/java/com/amazonaws/services/dynamodbv2/datamodeling/ConversionSchemas.java#L1301
@debora-ito debora-ito added the needs-triage This issue or PR still needs to be triaged. label Aug 2, 2021
@debora-ito debora-ito added feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 24, 2022
@debora-ito
Copy link
Member

We don't have plans to make this change in v1.

We are closing stale v1 issues before going into Maintenance Mode, so if this issue is still relevant in v2 please open a new issue in the v2 repo.

Reference:

  • Announcing end-of-support for AWS SDK for Java v1.x effective December 31, 2025 - blog post

@debora-ito debora-ito closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
@github-actions GitHub Actions
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debora-ito debora-ito

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debora-ito @tungpham