Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include support for AnalyticsMetadata in initiateAuthRequest and InitiateSRPAuthrequest #147

Closed
2 tasks
rajneeshmadan opened this issue Jun 19, 2024 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. module/cognito-ext p2 This is a standard priority issue queued

Comments

@rajneeshmadan
Copy link

Describe the feature

In Cognito provider with initiateAuthRequest and other API.. AnalyticsMetadata is supported but is not added in this extension.

Use Case

For Pinpoint Analytics this field is required

Proposed Solution

Change InitiateAuthRequest and InitiateRequest to add Analyticsmetatdata attribute as well (similare to clientmetadata)

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWS SDK

Targeted .NET Platform

.Net framework 4.7

Operating System and version

Windows

@rajneeshmadan rajneeshmadan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2024
@bhoradc bhoradc added module/cognito-ext needs-review p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2024
@bhoradc
Copy link

bhoradc commented Jun 19, 2024

Hello @rajneeshmadan,

Thank you for submitting this feature request. This looks a reasonable ask especially when the Cognito API (e.g. InitiateAuthRequest) supports the Analyticsmetatdata property.

I will further review this with the .NET SDK team. Thank you.

Regards,
Chaitanya

@rajneeshmadan
Copy link
Author

Thanks for working on this.. I see PR is still not merged. Please help by prioritizing it.

@ashishdhingra
Copy link
Contributor

Changes released in Amazon.Extensions.CognitoAuthentication 2.5.5.

Copy link

github-actions bot commented Jul 9, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/cognito-ext p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

3 participants