Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified login pages follow-up: Style Register and Reset Password links #6803

Open
quicksketch opened this issue Jan 3, 2025 · 5 comments · May be fixed by backdrop/backdrop#4971
Open

Comments

@quicksketch
Copy link
Member

quicksketch commented Jan 3, 2025

Description of the need

Every time I've shown the new simplified login links, I've had to explain that it "looks better" when there are two links, or describe a single link is in an <ul> tag. We should style these links so they look good even if there's only a single one.

Current screenshot:

image

Proposed solution

Hide the default bullets and center the link items in Seven only. Leave contrib themes to imitate or style as desired, since this is opinionated:

One link:
image

Two links:
image

Hypothetical wrapped links:
(I couldn't think of a way to style this without resulting in a trailing/leading dot)
image

@olafgrabienski
Copy link

Yay, this looks so much better than the default list style. I've had a look at the sandbox, works for me, also on the other login pages (user/register and user/password).

@argiepiano
Copy link

argiepiano commented Jan 3, 2025

Personally I don't mind the bullets. I find this centered list a bit strange, but that may be just me.

On the other hand, since this change is only happening for Seven, this will be lost when choosing a different backend theme, or choosing the front end theme for the simplilfied login.. And we have to be careful about making it global, as it will affect the bullets in the "links" appearance too, which will look pretty strange given that we are using the front end theme for the "links" appearance".

@docwilmot
Copy link
Contributor

I actually prefer the bullets, also find the centering a bit strange. Maybe nicer bullets?

@indigoxela
Copy link
Member

I left some comments on the PR. Suggestions for consideration mostly. 😉

Personally, I'm also fine with the current ul display, but also see the visual improvement. Not sure about the centering, but I'm fine with it, too.

@avpaderno
Copy link
Member

I like how the links are rendered, but I also do not dislike the links rendered as bullet list.

I would like more the new style if also other themes could use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants