Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero image - dimension limits ignored when selecting from library #6822

Open
indigoxela opened this issue Jan 11, 2025 · 0 comments
Open

Hero image - dimension limits ignored when selecting from library #6822

indigoxela opened this issue Jan 11, 2025 · 0 comments

Comments

@indigoxela
Copy link
Member

indigoxela commented Jan 11, 2025

Description of the bug

Recently the ability has been added to hero blocks to select existing images. (Finally! Yay!)

But for existing images the dimension limits are completely ignored.

Steps To Reproduce

  1. Open the hero block on the home page
  2. As hero image select one of the cards images
  3. Save

Actual behavior

The cards are 800px wide, nowhere near to the required 1200px (claimed by the field help text). But they're accepted and inserted without nagging.

novalidation

Expected behavior

Nagging according to min width setting,

Additional information

It seems like when improving the settings, somewhere on the road the validation was dropped (or never added).
Validation for uploads work as expected.

I'm aware that selecting existing images from library is a bit flaky, but if the text claims that there's a min setting, I'd expect some validation.

It's not urgent, just one of those WTF, that should be fixed...

  • Backdrop CMS version: 1.30.x-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant