Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle incompatible erc4626 in aggregator query #1404

Open
franzns opened this issue Dec 30, 2024 · 2 comments
Open

handle incompatible erc4626 in aggregator query #1404

franzns opened this issue Dec 30, 2024 · 2 comments
Assignees
@franzns

Comments

@franzns
Copy link
Collaborator

franzns commented Dec 30, 2024 •
edited
Loading

aggregators dont want to handle edge cases on their end so we'll do it in our query.

for the aggregatorPool query we'll need to treat the token as a non-erc4626 if the buffer is blocked
@franzns
Copy link
Collaborator Author

franzns commented Jan 3, 2025

suggested that aggregators check the isBlockedBuffer flag instead

@franzns franzns self-assigned this Jan 6, 2025
@franzns franzns changed the title remove underlying if buffer is block for aggregator query handle incompatible erc4626 in aggregator query Jan 10, 2025
@franzns
Copy link
Collaborator Author

franzns commented Jan 10, 2025

current outline https://www.notion.so/Compatible-ERC4626-Process-176e395e2281802e9c3dec02121099f2?pvs=4&cookie_sync_completed=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franzns franzns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franzns