-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing/Rescanning super issue #1195
Comments
8 tasks
We will discuss on this on Tues at the call but your recommendations above all look good to me. I'll start updating #1194 unless anyone has already started working on it or thinks it'd be better to start a new PR. |
38 tasks
Given Evan's PR (#1178 ), I believe the checkpoint fields on both structs don't have to be an option anymore. |
54 tasks
Adding this draft PR to the discussion: vladimirfomene#2 |
55 tasks
notmandatory
added
module-blockchain
module-wallet
and removed
new feature
New feature or request
labels
Mar 18, 2024
completed with #1403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There seems to be quite a few independent efforts to define and address problems with the syncing/scanning API. I thought it would be nice to organize them in one place and have a single PR that does all of them.
stop_gap
style scanning must necessarily be assuming that another wallet must have given out addresses prior to this one. The namerescan
communicates this better (h/t @danielabrozzoni). Relatedscan_without_keychain
andscan
's names should be inverted #1112.bdk_chain
that define bundles of things aWallet
(or any other system) could be interested in. I think these should be:Box<dyn Iterator<Item = ...>>
. Then when you add a new items to theSyncRequest
it should be something likeSyncRequest::append_spks(&mut self, spks: impl IntoIterator<Item=ScriptBuf>)
which would append the new iterator onto the existing one withchain
and replace it.The text was updated successfully, but these errors were encountered: