Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CombinedChangeSet back to bdk_wallet::ChangeSet #1496

Closed
notmandatory opened this issue Jul 2, 2024 · 2 comments · Fixed by #1514
Closed

Move CombinedChangeSet back to bdk_wallet::ChangeSet #1496

notmandatory opened this issue Jul 2, 2024 · 2 comments · Fixed by #1514
Assignees
@evanlinjin
Labels
api A breaking API change module-blockchain module-wallet
Milestone
1.0.0-alpha

Comments

@notmandatory
Copy link
Member

notmandatory commented Jul 2, 2024 •
edited
Loading

Sub-task for #1103
@notmandatory notmandatory added this to BDK Jul 2, 2024
@notmandatory notmandatory converted this from a draft issue Jul 2, 2024
@notmandatory notmandatory added the api A breaking API change label Jul 2, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jul 2, 2024
@evanlinjin evanlinjin self-assigned this Jul 2, 2024
@evanlinjin
Copy link
Member

This is in-progress and I'm working on it!

@notmandatory notmandatory moved this from Todo to In Progress in BDK Jul 2, 2024
@evanlinjin
Copy link
Member

So just a quick update on this. Because this affects bdk_sqlite crate, I had to start changing that as well. This is why this PR is taking longer than expected. I've decided to follow @LLFourn's suggestion on implementing a sqlite trait on each changeset (still WIP).

I'll continue on this work on Monday. Clocking off for the weekend!

@thunderbiscuit thunderbiscuit mentioned this issue Jul 5, 2024
Closed
5 tasks
@notmandatory notmandatory mentioned this issue Jul 5, 2024
Closed
@evanlinjin evanlinjin mentioned this issue Jul 17, 2024
Merged
5 tasks
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Jul 18, 2024
@notmandatory notmandatory moved this from Needs Review to Todo in BDK Jul 18, 2024
@notmandatory notmandatory moved this from Todo to Needs Review in BDK Jul 18, 2024
@notmandatory notmandatory moved this from Needs Review to In Progress in BDK Jul 18, 2024
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Jul 18, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
api A breaking API change module-blockchain module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

refactor(wallet)!: rework persistence, changeset, and construction evanlinjin/bdk
2 participants
@notmandatory @evanlinjin