You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the library is pretty unclear about the type of the type attribute of inputs:
should it be atoms?
should it be strings?
should both be supported?
I thought it's option 3 so I wrote this in ui_raw_input's documentation:
type - string or atom, defaults to :text
But all the showcase examples use atoms, and there is a check that assumes an atom:
<%= if @type == :checkbox do %>
If you try to use <.ui_input type="checkbox">, you get the elements in the wrong order for a checkbox: label first, input second.
Should we update the documentation and maybe add some runtime check to ensure that types are atoms? In our new client project, we used strings which lead to a problem with the checkboxes.
The text was updated successfully, but these errors were encountered:
I think the library is pretty unclear about the type of the
type
attribute of inputs:I thought it's option 3 so I wrote this in
ui_raw_input
's documentation:But all the showcase examples use atoms, and there is a check that assumes an atom:
If you try to use
<.ui_input type="checkbox">
, you get the elements in the wrong order for a checkbox: label first, input second.Should we update the documentation and maybe add some runtime check to ensure that types are atoms? In our new client project, we used strings which lead to a problem with the checkboxes.
The text was updated successfully, but these errors were encountered: