Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animsition not working in jQuery 3.4.1 - WORKAROUND #158

Open
neckarpixel opened this issue Oct 31, 2019 · 2 comments
Open

Animsition not working in jQuery 3.4.1 - WORKAROUND #158

neckarpixel opened this issue Oct 31, 2019 · 2 comments

Comments

@neckarpixel
Copy link

neckarpixel commented Oct 31, 2019

Hey Guys,
after not longer ignoring the newest jquery version i've tried a lot of methods to enable animsition
in jquery v3.*
I've found a solution without knowing why it is working. But it works.
The problem seems to be that the window Object is not available inside the function.
After reading a lot to this topic I add following lines

var loaded = false; $(window).on("load." + namespace, function() { loaded = true; }); var __ = { init: function(options) { //...

and

if(options.onLoadEvent) { if(loaded) { if(__.settings.timer) clearTimeout(__.settings.timer); __.in.call(_this); } else { $window.on("load", function(e) { if(__.settings.timer) clearTimeout(__.settings.timer); __.in.call(_this); }); }

However it works but I take no responsibility :)

I really hope, that the author will fix this correctly.

@arsusbravo
Copy link

arsusbravo commented Jan 28, 2020

Is that it?
Maybe because jquery 3.4.1 doesn't support load?
So this line might not work?
$window.on("load", function(e) { if(__.settings.timer) clearTimeout(__.settings.timer); __.in.call(_this); });

@rzuf666
Copy link

rzuf666 commented Feb 25, 2021

@Dhe Please, can you write exactly where and how this code needs to be added to make it work in the new jQuery?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants