Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No metrics collected for dialup IPsec VPNs #170

Open
jantari opened this issue May 17, 2022 · 1 comment · May be fixed by #176
Open

No metrics collected for dialup IPsec VPNs #170

jantari opened this issue May 17, 2022 · 1 comment · May be fixed by #176
Labels
bug Something isn't working

Comments

@jantari
Copy link

jantari commented May 17, 2022 •
edited
Loading

Hi and thank you very much for the great project.

Unfortunately I have noticed that all IPsec VPNs of type "dialup" are skipped entirely during metric collection:

fortigate_exporter/pkg/probe/vpn_ipsec.go

Lines 55 to 61 in 81adda5

/*
type 'dialup' seems to be client vpn.
Not sure exactly what the difference is between probeVPNSsl
*/
if i.Type == "dialup" {
continue
}

This obviously means that any dialup VPN cannot be monitored, which is the majority in our environment.
I confirmed with a manual curl API call that all our VPNs are returned by the /api/v2/monitor/vpn/ipsec endpoint, so it's just this exporter that then filters them out.

Could this continue statement be removed so that metrics for all IPsec VPNs are collected? I can make a PR for it too if you prefer.
@badbart badbart linked a pull request Jul 29, 2022 that will close this issue
Open
@bluecmd bluecmd added the bug Something isn't working label Aug 7, 2022
@jantari
Copy link
Author

jantari commented Jul 14, 2023

Any news on this? We utilize many IPSec dialup VPNs that we would like to monitor using this exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Continue on DialUp VPNs badbart/fortigate_exporter
2 participants
@bluecmd @jantari