full_name function broken

[DavidSagan]

julia> full_name(Species("He"))
ERROR: DimensionError: 2 and 0 e are not dimensionally compatible.
Stacktrace:
 [1] _lt
   @ ~/.julia/packages/Unitful/GYzMo/src/quantities.jl:243 [inlined]
 [2] <(x::Quantity{Int64, NoDims, Unitful.FreeUnits{(), NoDims, nothing}}, y::Quantity{Int64, 𝐈 𝐓, Unitful.FreeUnits{(e,), 𝐈 𝐓, nothing}})
   @ Unitful ~/.julia/packages/Unitful/GYzMo/src/quantities.jl:233
 [3] <(x::Int64, y::Quantity{Int64, 𝐈 𝐓, Unitful.FreeUnits{(e,), 𝐈 𝐓, nothing}})
   @ Unitful ~/.julia/packages/Unitful/GYzMo/src/quantities.jl:235
 [4] >(x::Quantity{Int64, 𝐈 𝐓, Unitful.FreeUnits{(e,), 𝐈 𝐓, nothing}}, y::Int64)
   @ Base ./operators.jl:379
 [5] full_name(species::Species)
   @ AtomicAndPhysicalConstants ~/.julia/dev/AtomicAndPhysicalConstants/src/particle_functions.jl:103
 [6] top-level scope
   @ REPL[11]:1

[rot4te]

Fixed in the full_name_fix PR

[DavidSagan]

@rot4te full_name still is broken for atomic species (but sub-atomic is OK). Also changing the name of the function to nameof would be in keeping with the naming of the other functions.

[rot4te]

Very odd. In my environment it works for everything. Nameof is also exported by Julia.base, so full_name is an easier choice.

…

On Dec 12, 2024, at 2:20 PM, David Sagan ***@***.***> wrote: @rot4te <https://github.com/rot4te> full_name still is broken for atomic species (but sub-atomic is OK). Also changing the name of the function to nameof would be in keeping with the naming of the other functions. — Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APVF2CGXE3534IHP66A6QB32FHOZJAVCNFSM6AAAAABTAWTFLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZHAZDSMJYGQ>. You are receiving this because you were mentioned.

[DavidSagan]

@rot4te Looks like the problem is that in the full_name function something like:

elseif species.charge == -1

is trying to compare species.charge which has units with -1 which does not have units.

[rot4te]

Yes, and I fixed that (by species.charge.val == -1) locally, and thought it was included in my push. Guess I’ll check it again.

…

On Dec 12, 2024, at 3:23 PM, David Sagan ***@***.***> wrote: @rot4te <https://github.com/rot4te> Looks like the problem is that in the full_name function something like: elseif species.charge == -1 is trying to compare species.charge which has units with -1 which does not have units. — Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APVF2CA2C5DPEXOERM4L3C32FHWFPAVCNFSM6AAAAABTAWTFLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZHE2DMMJXGU>. You are receiving this because you were mentioned.