Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 mk drift #37

Merged
merged 23 commits into from
Jan 20, 2025
Merged

4 mk drift #37

merged 23 commits into from
Jan 20, 2025

Conversation

dtabell
Copy link
Collaborator

@dtabell dtabell commented Jan 14, 2025

Updated the drift and quadrupole integrators.
Added tests for both integrators.

dtabell and others added 20 commits November 12, 2024 14:56
@dtabell
Remove trailing spaces.
f84faf0
@dtabell
Change Symplectic -> MatrixKick.
a3a2800
@dtabell
Merge branch 'main' into 4-mk-drift
ff5504b
@dtabell
Update drift testing.
7304b81
@dtabell
Fix bug in computation of z-final.
4540b22
@dtabell
Correct drift test data.
e75b0dc
@dtabell
Insert comment re constraints on drift tracker.
8225e26
@dtabell
Update and correct quadrupole integrator.
271ce58
@dtabell
Add test for quadrupole. (does not yet pass)
eaaea4b
@dtabell
Adjust format: delete trailing blank.
3bf744b
@dtabell
Fix multiple bugs.
b66ea09
@dtabell
Fix 5 keV tests for quadrupole.
fe25862
@dtabell
Convert to using AtomicAndPhysicalConstants.jl.
0fa9a57
@dtabell
Add quadrupole tests at multiple energies.
19f3bb0
@dtabell
Correct c_light for dependence on AAPC.
7796e61
@dtabell
Add initialization of AAPC.
8c0e034
@dtabell
Add more tests for drifts and quads.
11669c1
@dtabell
Merge branch 'main' into 4-mk-drift
a2d7846
@dtabell
Correct Beam/beam to Bunch/bunch where needed.
699da0b
@dtabell
include my drift and quad tests into run_tests.jl.
8b38770
@dtabell
Copy link
Collaborator Author

dtabell commented Jan 17, 2025

So ... when I use a relative tolerance of 5e-13, all tests pass on my machine.
But looking at the CI Julia 1.11 test results, I see some tests failing with relative errors of order unity!
Extremely puzzling.

@dtabell dtabell merged commit c206f0b into main Jan 20, 2025
3 checks passed
@dtabell dtabell deleted the 4-mk-drift branch January 20, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsignorelli mattsignorelli Awaiting requested review from mattsignorelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtabell @mattsignorelli