Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of word Kaavio in various places #6

Open
jacobwindsor opened this issue Mar 1, 2017 · 7 comments
Open

Use of word Kaavio in various places #6

jacobwindsor opened this issue Mar 1, 2017 · 7 comments
Labels

Comments

@jacobwindsor
Copy link
Collaborator

In the Typescript branch, there is the use of the word Kaavio in various places. Am I wrong in thinking that this project is separate from Kaavio and would, in fact, be used in PVJS? See this file name, this line, and there are a couple of others I think.

Either way, I think it is confusing to have the names Kaavio or PVJS used anywhere since this library could be used independently from either.

@jacobwindsor
Copy link
Collaborator Author

@ariutta is the UI directory meant to be moved to PVJS itself?

@ariutta
Copy link
Collaborator

ariutta commented Mar 2, 2017

Yes, bridgedbjs is separate from Kaavio, and any reference to Kaavio should be removed.

But the UI directory is supposed to be part of bridgedbjs. It is simply some UI elements that could be useful for interacting with the BridgeDb webservice, and it could be used entirely independently of pvjs.

@ariutta ariutta closed this as completed Mar 2, 2017
@ariutta ariutta reopened this Mar 2, 2017
@ariutta
Copy link
Collaborator

ariutta commented Mar 2, 2017

Reopening so we can close it when any reference to Kaavio and/or Pvjs is removed.

@ariutta
Copy link
Collaborator

ariutta commented Mar 2, 2017

The TypeScript branch is pretty much ready to release, so if you don't see any other issues with it, you could merge it into master. It's currently in pre-release on npm: https://www.npmjs.com/package/bridgedb

@jacobwindsor
Copy link
Collaborator Author

Okay, great. I'll make some time for removing kaavio/pvjs references at some point

@ariutta
Copy link
Collaborator

ariutta commented Mar 2, 2017

To clarify my comment about it being ready for release, the API client is totally ready. The UI components are the only parts I'm not sure about. They are pretty good, but I just haven't tested them fully (manual cross-browser inspection, automated tests, etc.).

@jacobwindsor
Copy link
Collaborator Author

Today, I got the UI components working in PVJS. It looks nice. However, one thing is that you cannot drag the box around like you can in current WP. I don't know if that's intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants